Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make pipeline-catalog submodule available to built Docker image #373

Merged
merged 5 commits into from
Nov 5, 2024
Merged

[FIX] Make pipeline-catalog submodule available to built Docker image #373

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0612d0
check out submodules before building Docker image
alyssadai Nov 4, 2024
9628dfc
only copy required files into Docker image
alyssadai Nov 4, 2024
18c3226
expand ignore patterns in .dockerignore
alyssadai Nov 5, 2024
af1dd7a
reorder .dockerignore
alyssadai Nov 5, 2024
8676d0c
revert changes to Dockerfile
alyssadai Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build_docker_nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive

- name: Login to Docker Hub
uses: docker/login-action@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_docker_on_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
-
name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive
-
# The release event is a superset of the push tag event,
# so we expect two tags to be generated by docker/metadata-action
Expand Down
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
FROM python:3.10-slim-buster

WORKDIR /app
COPY . /app/src
COPY requirements.txt pyproject.toml setup.cfg setup.py /app/src/
COPY bagel /app/src/bagel
COPY pipeline-catalog /app/src/pipeline-catalog

# To have a deterministic build, we
# 1. install the environment from our lockfile
RUN pip install -r /app/src/requirements.txt
Expand Down
Loading