Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ensure pipeline variables are returned from the graph in an aggregate query #349

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 10, 2024

Changes proposed in this pull request:

  • added pipeline_name and pipeline_version to list of variables returned in the aggregate graph response
  • updated API-side graph response handling to return pipeline info even in aggregate mode
  • minor conditional rewriting for clearer logic

Note: In this case, some tests started failing after the graph response handling logic was updated, since the mocked aggregate response from the graph used in those tests no longer matched the expected format (good). However, we are not yet to write a test that would fail under the original bug conditions (bad), since this would require a graph with data to test against. See #283

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11266360515

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.507%

Totals Coverage Status
Change from base Build 11261813541: 0.1%
Covered Lines: 744
Relevant Lines: 779

💛 - Coveralls

@surchs surchs self-requested a review October 10, 2024 13:57
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai for the bug find and fix.

Agree that we should find a way to test e2e with a real graph so we can test unmocked query responses against our expectations.

🧑‍🍳

@alyssadai alyssadai added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Oct 10, 2024
@alyssadai alyssadai merged commit e3e1429 into main Oct 10, 2024
10 checks passed
@alyssadai alyssadai deleted the fix-agg-query branch October 10, 2024 15:39
Copy link
Contributor

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Aggregate API responses always contain empty dict for available_pipelines
3 participants