Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update pre-commit CI config #256

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[CI] Update pre-commit CI config #256

merged 1 commit into from
Jan 17, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jan 17, 2024 •
edited by surchs
Loading

Note: different Python repos require different pre-commit hooks, so autofix: False has to be set manually in each .pre-commit-config.yaml

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the skip-release PR doesn't appear in the changelog and preserves current version when merged label Jan 17, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7560656871

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.771%
Totals Coverage Status
Change from base Build 7492197317: 0.0%
Covered Lines: 873
Relevant Lines: 875
💛 - Coveralls

surchs
surchs approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🧑‍🍳

unrelated: why does this PR not have the new PR template (with the label-checkbox)?

@alyssadai
Copy link
Contributor Author

@surchs, because the PR with the new template is not merged yet, pending this fix of the pre-commit check failures:

https://github.com/neurobagel/api/pull/255/files

@alyssadai alyssadai merged commit 6ad07ae into main Jan 17, 2024
6 checks passed
@alyssadai alyssadai deleted the alyssadai-patch-1 branch January 17, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit CI fails on hooks with 'local' dependencies
3 participants
@alyssadai @coveralls @surchs