You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
surchs opened this issue
Feb 28, 2024
· 1 comment
· Fixed by #357
Assignees
Labels
processImprovement to internal processesreleasedThis issue/pull request has been released.somedayNot a priority right now, but we want to keep this around to think or discuss more.
either spin up the local PR branch directly and connect to the Graph by hand OR
build a new docker image from the local PR branch, edit the docker-compose.yml and then spin up the local branch API with the graph
That's silly work and a bot should do it. As part of a test. We should be most of the way there already, but the rest is probably still a good bit of work.
The crucial part of the issue entails testing that the query template returns expected results, rather than the content of the query string itself. Specifically, this may requiring construct test queries, and then asserting over responses from the graph.
processImprovement to internal processesreleasedThis issue/pull request has been released.somedayNot a priority right now, but we want to keep this around to think or discuss more.
#282 is a good example of a PR that looks good but to be completely sure a reviewer would have to
That's silly work and a bot should do it. As part of a test. We should be most of the way there already, but the rest is probably still a good bit of work.
The crucial part of the issue entails testing that the query template returns expected results, rather than the content of the query string itself. Specifically, this may requiring construct test queries, and then asserting over responses from the graph.
This would help catch issues such as:
The text was updated successfully, but these errors were encountered: