-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to drop views during DropCommand #1038
Conversation
* @throws RuntimeException | ||
* @throws \Magento\Framework\Exception\FileSystemException | ||
*/ | ||
public function getViews($withoutPrefix = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copied from getTables function, has to be tested and developed
c01e979
to
288932e
Compare
@torhoehn nice. I will review that after the next release if it's ok. Or we discuss it in Cologne :-) |
@cmuench I'm sure you could teach me something there. :) |
@torhoehn I didn't forget your PR. I plan to merge this feature in the v7.0.0 release. |
288932e
to
b0f62ca
Compare
This conflicts with the global Symfony verbose option.
@torhoehn I remove the "-v" shortcut. This produces an error, because the "-v" option is already reserved as global shortcut of the verbose option in Symfony Commands. |
I tested the drop function. The generated SQL query looks like this: I left the "echo" statement in the code for debugging. |
I close this MR until we have refactored the command. |
Magerun pull-request check-list:
Summary: (some words as summary)
Fixes #602.
Changes proposed in this pull request: