Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added template support for cisco_fxos show system firmware #1967

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

manofcolombia
Copy link
Contributor

There are currently no other cisco_fxos templates and I ran into a need to check both the running firmware against the startup firmware version in order to confirm that an upgrade was successful (you would think the api would let you confirm this but alas...no) so I made this template to scrape that info from cli.

@mjbear
Copy link
Contributor

mjbear commented Jan 10, 2025

@manofcolombia
I figured out what needed to be fixed for the test cases and submitted a PR to your fork. This way you can merge my PR into your branch to have this fixed up! manofcolombia#1

Fix up test_index_order test for cisco_fxos_show_system_firmware
@manofcolombia
Copy link
Contributor Author

@mjbear Thank you. When I ran the tests locally it appeared to me that the failure was irrelevant to my commit, but now I understand what was going on and that I missed adding the new OS into the testing phase altogether. I will note this for myself.

@mjbear
Copy link
Contributor

mjbear commented Jan 10, 2025

@mjbear Thank you. When I ran the tests locally it appeared to me that the failure was irrelevant to my commit, but now I understand what was going on and that I missed adding the new OS into the testing phase altogether. I will note this for myself.

No worries @manofcolombia. Glad to assist.

I don't believe in all my commits that I've added templates to an OS that didn't have them, so this was a new item for me. haha 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants