-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hp_comware_display_interface_brief.textfsm #1964
Open
juliencorsini
wants to merge
5
commits into
networktocode:master
Choose a base branch
from
juliencorsini:juliencorsini-patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
920d421
Update hp_comware_display_interface_brief.textfsm
juliencorsini 44cff27
Update hp_comware_display_interface_brief.textfsm
juliencorsini 9ca634f
Add test data for HP Comware full auto ports
mjbear 40d2605
Merge pull request #1 from mjbear/hp_comware_disp_int_br_pr1964
juliencorsini 45326fb
Merge branch 'networktocode:master' into juliencorsini-patch-2
juliencorsini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,7 +3,7 @@ Value LINK (\S+) | |||||
Value PROTOCOL ((?:UP|DOWN)(?:\(s\))?) | ||||||
Value MAIN_IP (\S+) | ||||||
Value SPEED (\S+) | ||||||
Value DUPLEX (A|H|F) | ||||||
Value DUPLEX (\S+) | ||||||
Value TYPE (A|T|H) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on the test data that is present, we can also simplify this regex.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jmcgill298 @jvanderaa |
||||||
Value PVID (\d+) | ||||||
Value DESCRIPTION (.*?) | ||||||
|
15 changes: 15 additions & 0 deletions
15
tests/hp_comware/display_interface_brief/hp_comware_display_interface_brief_fullauto.raw
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
The brief information of interface(s) under route mode: | ||
Link: ADM - administratively down; Stby - standby | ||
Protocol: (s) - spoofing | ||
Interface Link Protocol Main IP Description | ||
M-GE0/0/0 ADM DOWN -- | ||
NULL0 UP UP(s) -- | ||
Vlan1081 UP UP 1.2.3.6 | ||
|
||
The brief information of interface(s) under bridge mode: | ||
Link: ADM - administratively down; Stby - standby | ||
Speed or Duplex: (a)/A - auto; H - half; F - full | ||
Type: A - access; T - trunk; H - hybrid | ||
Interface Link Speed Duplex Type PVID Description | ||
BAGG10 UP 20G(a) F(a) T 4094 mydescr | ||
BAGG11 UP 20G(a) F(a) T 4094 mydescr |
47 changes: 47 additions & 0 deletions
47
tests/hp_comware/display_interface_brief/hp_comware_display_interface_brief_fullauto.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
--- | ||
parsed_sample: | ||
- description: "" | ||
duplex: "" | ||
interface: "M-GE0/0/0" | ||
link: "ADM" | ||
main_ip: "--" | ||
protocol: "DOWN" | ||
pvid: "" | ||
speed: "" | ||
type: "" | ||
- description: "" | ||
duplex: "" | ||
interface: "NULL0" | ||
link: "UP" | ||
main_ip: "--" | ||
protocol: "UP(s)" | ||
pvid: "" | ||
speed: "" | ||
type: "" | ||
- description: "" | ||
duplex: "" | ||
interface: "Vlan1081" | ||
link: "UP" | ||
main_ip: "1.2.3.6" | ||
protocol: "UP" | ||
pvid: "" | ||
speed: "" | ||
type: "" | ||
- description: "mydescr" | ||
duplex: "F(a)" | ||
interface: "BAGG10" | ||
link: "UP" | ||
main_ip: "" | ||
protocol: "" | ||
pvid: "4094" | ||
speed: "20G(a)" | ||
type: "T" | ||
- description: "mydescr" | ||
duplex: "F(a)" | ||
interface: "BAGG11" | ||
link: "UP" | ||
main_ip: "" | ||
protocol: "" | ||
pvid: "4094" | ||
speed: "20G(a)" | ||
type: "T" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the test data that is present, we can simplify this regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcgill298 @jvanderaa
Thoughts on this regex too?