Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hp_comware_display_interface_brief.textfsm #1964

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Value LINK (\S+)
Value PROTOCOL ((?:UP|DOWN)(?:\(s\))?)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the test data that is present, we can simplify this regex.

Suggested change
Value PROTOCOL ((?:UP|DOWN)(?:\(s\))?)
Value PROTOCOL (\S+)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcgill298 @jvanderaa
Thoughts on this regex too?

Value MAIN_IP (\S+)
Value SPEED (\S+)
Value DUPLEX (A|H|F)
Value DUPLEX (\S+)
Value TYPE (A|T|H)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the test data that is present, we can also simplify this regex.

Suggested change
Value TYPE (A|T|H)
Value TYPE (\S+)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value PVID (\d+)
Value DESCRIPTION (.*?)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
The brief information of interface(s) under route mode:
Link: ADM - administratively down; Stby - standby
Protocol: (s) - spoofing
Interface Link Protocol Main IP Description
M-GE0/0/0 ADM DOWN --
NULL0 UP UP(s) --
Vlan1081 UP UP 1.2.3.6

The brief information of interface(s) under bridge mode:
Link: ADM - administratively down; Stby - standby
Speed or Duplex: (a)/A - auto; H - half; F - full
Type: A - access; T - trunk; H - hybrid
Interface Link Speed Duplex Type PVID Description
BAGG10 UP 20G(a) F(a) T 4094 mydescr
BAGG11 UP 20G(a) F(a) T 4094 mydescr
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
---
parsed_sample:
- description: ""
duplex: ""
interface: "M-GE0/0/0"
link: "ADM"
main_ip: "--"
protocol: "DOWN"
pvid: ""
speed: ""
type: ""
- description: ""
duplex: ""
interface: "NULL0"
link: "UP"
main_ip: "--"
protocol: "UP(s)"
pvid: ""
speed: ""
type: ""
- description: ""
duplex: ""
interface: "Vlan1081"
link: "UP"
main_ip: "1.2.3.6"
protocol: "UP"
pvid: ""
speed: ""
type: ""
- description: "mydescr"
duplex: "F(a)"
interface: "BAGG10"
link: "UP"
main_ip: ""
protocol: ""
pvid: "4094"
speed: "20G(a)"
type: "T"
- description: "mydescr"
duplex: "F(a)"
interface: "BAGG11"
link: "UP"
main_ip: ""
protocol: ""
pvid: "4094"
speed: "20G(a)"
type: "T"