Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cisco_ios_show_ip_interface_brief #1958

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update cisco_ios_show_ip_interface_brief #1958

merged 2 commits into from
Jan 7, 2025

Conversation

averhaven
Copy link
Contributor

I want to be able to parse interfaces with the status 'deleted' for the show command 'show ip interface brief' for the platform 'cisco_ios'

mjbear
mjbear approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@mjbear mjbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the raw output realistic with the interface being a sub-interface. 🙂

Looks good.

@jmcgill298 jmcgill298 merged commit 9e26cc0 into networktocode:master Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbear mjbear mjbear approved these changes

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averhaven @jmcgill298 @mjbear