Add Fsas Si-R show system information template #1956
Conversation
caribouHY
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
ntc_templates/templates/fsas_sir_show_system_information.textfsm
Outdated
Show resolved
Hide resolved
| Value FIRMWARE (firmware\d) | ||
| Value CONFIG_FILE (config\d) |
There was a problem hiding this comment.
I'm on the fence whether it's better to just match these two with a simpler regex.
Which way do you lean on the topic?
There was a problem hiding this comment.
I think that FIRMWARE and CONFIG name may change in the future.
I fixed the regex.
Value FIRMWARE (\S+)
Value CONFIG_FILE (\S+)
ntc_templates/templates/fsas_sir_show_system_information.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/fsas_sir_show_system_information.textfsm
Outdated
Show resolved
Hide resolved
| ^USB\d?\s+:\s+.+$$ | ||
| ^WWAN\d?\s+.+$$ |
There was a problem hiding this comment.
@caribouHY
Do you have test output that covers USB (and WWAN) followed by a number?
The question and goal is to have good test coverage. Thank you!
There was a problem hiding this comment.
I added a test case from command reference. I don't hava a device supported Wireless WAN and multiple USB ports.
There was a problem hiding this comment.
I added a test case from command reference. I don't hava a device supported Wireless WAN and multiple USB ports.
Understood.
I'd say that's reasonable. Thank you.
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
ntc_templates/templates/fsas_sir_show_system_information.textfsm
Outdated
Show resolved
Hide resolved
ntc_templates/templates/fsas_sir_show_system_information.textfsm
Outdated
Show resolved
Hide resolved
tests/fsas_sir/show_system_information/fasa_sir_show_system_information3.raw
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob McGill <[email protected]>
Co-authored-by: Jacob McGill <[email protected]>
…formation3.raw Co-authored-by: Jacob McGill <[email protected]>
No description provided.