Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestFactory: rejects invalid URL [WIP] #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RequestFactory: rejects invalid URL [WIP] #41

wants to merge 2 commits into from

Conversation

dg
Copy link
Member

@dg dg commented Dec 27, 2014

See #30

@JanTvrdik
Copy link
Contributor

👍 This is exactly what I had in mind. Now we just need to figure out how to handle the invalid request 😄

Partially related to it – what should RequestFactory do when running in CLI? Because that is another form of invalid URL (or HTTP request in general).

You can remove the Strings::fixEncoding now as well.

@dg dg force-pushed the master branch 2 times, most recently from 6df6a37 to f17b437 Compare February 9, 2015 23:14
@dg dg added this to the v2.4 milestone Feb 17, 2015
@dg dg force-pushed the pull-invalid branch from 5fc99ff to b45ad0c Compare May 25, 2015 13:27
@dg dg force-pushed the pull-invalid branch 3 times, most recently from a2644ca to e76600e Compare June 19, 2015 17:03
@dg dg force-pushed the master branch 7 times, most recently from 1dc599c to f35d20f Compare November 5, 2015 00:41
@dg dg force-pushed the master branch 2 times, most recently from 7981e33 to 3fb64f5 Compare July 21, 2016 12:07
@dg dg force-pushed the master branch 3 times, most recently from b9f06ea to 4f6d6c9 Compare December 20, 2016 14:30
@dg dg force-pushed the master branch 4 times, most recently from 2a0c595 to 4ca7b03 Compare January 26, 2023 22:47
@dg dg force-pushed the master branch 6 times, most recently from da24b94 to 540335c Compare March 20, 2023 13:43
@dg dg force-pushed the master branch 2 times, most recently from e7c7e2d to bf945f3 Compare August 5, 2023 19:08
@dg dg force-pushed the master branch 3 times, most recently from 9a14e6e to a20fb8f Compare November 14, 2023 18:31
@dg dg force-pushed the master branch 5 times, most recently from 55488bd to 2042d2e Compare December 11, 2023 13:01
@dg dg force-pushed the master branch 2 times, most recently from 4960652 to 5e67add Compare May 2, 2024 10:56
@dg dg force-pushed the master branch 5 times, most recently from 689f4ae to 33aae19 Compare November 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dg @JanTvrdik