Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception code property must be int - DriverException.php #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matak
Copy link

@matak matak commented Apr 16, 2019

As PHP exception is defined with code of type int, there must be always int

public function __construct(string $message = "", int $code = 0, \Throwable $previous = NULL) {}

  • bug fix
  • BC break? no

As PHP exception is defined with code of type int, there must be always int

public function __construct(string $message = "", int $code = 0, \Throwable $previous = NULL) {}
@dg dg force-pushed the master branch 2 times, most recently from 4c0e8d0 to e17242a Compare November 19, 2019 18:28
@dg dg force-pushed the master branch 6 times, most recently from f9fc19d to dd75e74 Compare December 13, 2019 18:06
@dg dg force-pushed the master branch 2 times, most recently from cce6a9c to 7e705c5 Compare December 27, 2019 03:53
@dg dg force-pushed the master branch 2 times, most recently from 9acf825 to a268c60 Compare March 27, 2020 11:52
@dg dg force-pushed the master branch 2 times, most recently from a56e7fe to d9b5f29 Compare June 9, 2020 14:19
@dg dg force-pushed the master branch 2 times, most recently from f016c33 to 6596c77 Compare July 10, 2020 16:30
@dg dg force-pushed the master branch 2 times, most recently from a9e5763 to c3cc31a Compare October 6, 2020 17:24
@dg dg force-pushed the master branch 2 times, most recently from e91b234 to 953502b Compare October 15, 2020 22:53
@dg dg force-pushed the master branch 6 times, most recently from 52d72e1 to fd0d57c Compare October 30, 2020 13:01
@dg dg force-pushed the master branch 26 times, most recently from a329d1b to 9f82d9d Compare September 5, 2024 02:37
@dg dg force-pushed the master branch 2 times, most recently from 1769a67 to b02f117 Compare January 9, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant