fix: remove unused code and dependencies #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
fix/remove-dead-code
branch
2 times, most recently
from
47357da to
077013c
Compare
This is built into vitest now: https://vitest.dev/guide/cli#changed.
serhalp
force-pushed
the
fix/remove-dead-code
branch
from
077013c to
2ebd1ac
Compare
DanielSLew
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: remove unused code and dependencies
All found with Knip 👀 https://knip.dev/
chore: remove heavyweight
test:affectedThis is built into vitest now: https://vitest.dev/guide/cli#changed. It is definitely not worth several hundred lines of untyped code and four additional dev dependencies.