Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-2034] Otvorenie prvého viewu #261

Open
wants to merge 3 commits into
base: release/6.5.0
Choose a base branch
from
Open

[NAE-2034] Otvorenie prvého viewu #261

wants to merge 3 commits into from

Conversation

Retoocs
Copy link
Contributor

@Retoocs Retoocs commented Jan 30, 2025

Description

Implemented rule, that selects particular view of the menu item when clicked on folder or initialized menu. Also moved the code, that load and navigates through the menu in separate service and utils. This service holds the menu resources.

Implements NAE-2034

Dependencies

No dependency

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Manually and by tests

Test Configuration

Name Tested on
OS Ubuntu 24.04.1 LTS
Runtime Java 11
Dependency Manager Maven 3.6.3
Framework version Spring Boot 2.7.8
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @Kovy95
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

- implement resolving of auto-select views in double-drawer
- abstract loading and navigation in double drawer menu
- implement default view opening in double drawer menu
@Retoocs Retoocs added improvement New feature or request breaking change Fix or feature that would cause existing functionality doesn't work as expected labels Jan 30, 2025
@Retoocs Retoocs self-assigned this Jan 30, 2025
Kovy95
Kovy95 previously approved these changes Jan 30, 2025
- update tests according to changes
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.6% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fix or feature that would cause existing functionality doesn't work as expected improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants