Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-2021] Outputs for navigation components #254

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

tuplle
Copy link
Member

@tuplle tuplle commented Dec 2, 2024

Description

Added outputs to navigation components, mainly to navigation menus (i.e. double-drawer menu), for better event reaction in the final app.

Implements NAE-2021

Dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Tested on examples project in the mono-repo.

Test Configuration

Name Tested on
OS Linux
Runtime NodeJS 20
Dependency Manager NPM 10
Framework version Angular 13
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

 - add outputs to navigation components
@tuplle tuplle added the improvement New feature or request label Dec 2, 2024
@tuplle tuplle self-assigned this Dec 2, 2024
machacjozef
machacjozef previously approved these changes Dec 2, 2024
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.7% Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@machacjozef machacjozef merged commit d442e2b into release/6.4.0 Dec 2, 2024
8 of 10 checks passed
@machacjozef machacjozef deleted the NAE-2021 branch December 2, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants