-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1929] Data field type list of strings #227
Conversation
- add new datafield stringCollection and implement it as chip list
- change key codes
- fix responsivity - add semicolon and comma as property (you can ad property comma or semicolon as key and property value is true)
...-field/string-collection-default-field/abstract-string-collection-default-field.component.ts
Outdated
Show resolved
Hide resolved
- fix according to PR
|
||
ngOnInit() { | ||
if (this.dataField?.component?.properties?.semicolon === 'true') { | ||
this.separatorKeysCodes.push(SEMICOLON); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error in @angular/cdk/keycodes:
On Slovak keyboard layout for macOS, SEMICOLON
does not correspond to the expected input. Pressing ;
results in no response, but pressing ô
acts as a separator. Code adjustment is required for proper functionality of the ;
key to align with the Slovak keyboard layout on macOS.
- add creating a chip on blur on field
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Description
Implements NAE-1929
Dependencies
none
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
manual
Test Configuration
Checklist: