Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAE-1907] - Prompt user before leaving/reloading site when data does not need to be saved #208

Open
wants to merge 6 commits into
base: release/6.4.0
Choose a base branch
from

Merge branch 'release/6.4.0' into NAE-1907

5c84d5a
Select commit
Loading
Failed to load commit list.
Open

[NAE-1907] - Prompt user before leaving/reloading site when data does not need to be saved #208

Merge branch 'release/6.4.0' into NAE-1907
5c84d5a
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Sep 16, 2024 in 0s

15 / 15 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
prompt user with dialog when leaving/reloading site and focus is still in input of field (text/number/i18n) Incomplete
if user decide to stay on site, blur input field so data is saved Incomplete
My code follows the style guidelines of this project Completed
I have performed a self-review of my own code Completed
My changes have been checked, personally or remotely, with @RudeBoyxX @tuplle Completed
I have commented my code, particularly in hard-to-understand areas Completed
I have resolved all conflicts with the target branch of the PR Completed
I have updated and synced my code with the target branch Completed
I have added tests that prove my fix is effective or that my feature works Completed
Lint test Completed
Unit tests Completed
Integration tests Completed
SonarCloud Completed
Snyk Completed
Developer documentation Completed
User Guides Completed
Migration Guides Completed
Optimal size changes are more likely to be reviewed faster with fewer
iterations. Incomplete
Similarity in low PR complexity drives similar review times. Incomplete
Bugs are more likely to be detected. Incomplete
Code inconsistencies are more likely to be detected. Incomplete
Small portions can be assimilated better. Incomplete
Solving big problems by dividing them in well contained, smaller problems. Incomplete
Exercising separation of concerns within the code changes. Incomplete
Create a context profile for your repo using the context generator Incomplete
Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile. Incomplete
Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile. Incomplete
Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile. Incomplete
Your PR could be split in smaller, self-contained PRs instead Incomplete
Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). Incomplete
One line was added: +1 -0 Incomplete
One line was deleted: +0 -1 Incomplete
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion) Incomplete
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository. Incomplete