-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1544] Timezone for Date a DateTime field #119
base: release/6.4.0
Are you sure you want to change the base?
Conversation
- added timezone offset to http request
- implemented tests.
- time zone added to hint of field. - implemented two components for dateTimeField.
- correcting tests
- correcting tests
Kudos, SonarCloud Quality Gate passed! |
AbstractSimpleDateTimeFieldComponent, | ||
DATE_TIME_FORMAT, | ||
NAE_INFORM_ABOUT_INVALID_DATA | ||
} from 'netgrif-components-core'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected
- corrected bad import
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/public-api.ts # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Kudos, SonarCloud Quality Gate passed! |
# Conflicts: # projects/netgrif-components-core/src/lib/data-fields/public-api.ts # projects/netgrif-components/src/lib/data-fields/data-fields.module.ts # projects/netgrif-components/src/lib/data-fields/date-time-field/date-time-field.component.html
- updated according to PR
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description
Added time zone conversion to date
Implements NAE-1544
Dependencies
No new dependencies were introduced.
Third party dependencies
No new dependencies were introduced.
Blocking Pull requests
There are no dependencies on other PR.
How Has Been This Tested?
This was tested manually and using unit tests.
Test Configuration
Checklist: