Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganise the chart with one folder per component #405

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jouve
Copy link
Contributor

@jouve jouve commented Feb 8, 2024

a benefit is that config/checksum annotation is now calculated exactly for its own configmap, so changing a parent config won't restart the daemonset for example.

@jouve jouve requested review from Ferroin, ilyam8 and a team as code owners February 8, 2024 16:15
@jouve jouve requested review from witalisoft and M4itee February 8, 2024 16:15
@M4itee
Copy link
Contributor

M4itee commented Feb 9, 2024

@jouve Thanks for this PR. It looks much better and solves a real problem. We need to test this on our own to make sure that it will not break the existing setups.

@witalisoft
Copy link
Contributor

LGTM good job 👍

@M4itee M4itee merged commit b02e4a3 into netdata:master Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants