C端用户 #63
Open
C端用户 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hirdPartyProvider枚举；优化UserDeliveryAddress和UserThirdPartyLogin实体的内部方法实现
…ity Framework Core至9.0.0版本
…；优化代码格式和命名空间引用；移除冗余代码
…UserLoginHistory实体及相关命令处理逻辑；优化代码结构
witskeeper
reviewed
Mar 4, 2025
| if (PasswordHash != passwordHash) | ||
| { | ||
| PasswordFailedTimes++; | ||
| throw new KnownException("用户名或密码错误"); |
There was a problem hiding this comment.
这里如果throw 的话， PasswordFailedTimes就不会被保存了
| { | ||
| builder.ToTable("clientUsers"); | ||
| builder.HasKey(cu => cu.Id); | ||
| builder.Property(cu => cu.Id).ValueGeneratedOnAdd().UseSnowFlakeValueGenerator(); |
| { | ||
| builder.ToTable("clientUserLoginHistory"); | ||
| builder.HasKey(a => a.Id); | ||
| builder.Property(a => a.Id).ValueGeneratedOnAdd().UseSnowFlakeValueGenerator(); |
| { | ||
| RuleFor(x => x.NickName).NotEmpty().WithMessage("昵称不能为空"); | ||
| RuleFor(x => x.Phone).NotEmpty().WithMessage("手机号不能为空"); | ||
| RuleFor(x => x.PasswordHash).NotEmpty().WithMessage("密码不能为空"); |
| request.PasswordHash, | ||
| request.PasswordSalt, | ||
| request.Email); | ||
| clientUserRepository.Add(user); |
| request.UserAgent | ||
| )); | ||
|
|
||
| var token = tokenGenerator.GenerateJwtAsync([ |
There was a problem hiding this comment.
jwt的功能，可以使用框架提供的jwt私钥存储和token生成功能
| } | ||
|
|
||
| [HttpPut] | ||
| public async Task<ResponseData> Disable([FromBody] ClientUserDisableRequest request) |
| public async Task<ResponseData> AddDeliveryAddress([FromBody] AddDeliveryAddressRequest request) | ||
| { | ||
| return await mediator.Send(new ClientUserAddDeliveryAddressCommand( | ||
| request.UserId, |
There was a problem hiding this comment.
c端用户的操作的命令中，userid 应该从当前登录身份中获取，否则会出现权限泄露的可能性，a用户可以修改b用户的数据
| public async Task<ResponseData> RemoveDeliveryAddress([FromQuery] RemoveDeliveryAddressRequest request) | ||
| { | ||
| return await mediator.Send(new ClientUserRemoveDeliveryAddressCommand( | ||
| request.UserId, |
|
|
||
| namespace NetCorePal.D3Shop.Web.Helper; | ||
|
|
||
| public class TokenGenerator(IOptions<AppConfiguration> appConfiguration) |
There was a problem hiding this comment.
…结果；调整登录方法返回类型，改进错误处理和响应结构
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.