Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New profile: device-flasher.linux (CalyxOS) #6616

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

lucasmz-dev
Copy link
Contributor

@lucasmz-dev lucasmz-dev commented Jan 15, 2025

The CalyxOS CLI device flasher.

etc/profile-a-l/device-flasher.linux.profile Outdated Show resolved Hide resolved
etc/profile-a-l/device-flasher.linux.profile Show resolved Hide resolved
etc/profile-a-l/device-flasher.linux.profile Outdated Show resolved Hide resolved
etc/profile-a-l/device-flasher.linux.profile Outdated Show resolved Hide resolved
etc/profile-a-l/device-flasher.linux.profile Outdated Show resolved Hide resolved
etc/profile-a-l/device-flasher.linux.profile Outdated Show resolved Hide resolved
@kmk3 kmk3 marked this pull request as draft January 20, 2025 08:46
@kmk3 kmk3 changed the title New profile: device-flasher.linux New profile: device-flasher.linux (CalyxOS) Jan 31, 2025
@lucasmz-dev
Copy link
Contributor Author

I'll do a test later today with the changes (even if they're only really reordering AFAICT) and rebase/re-sign the commits with the proper credits

I should probably also look into the stuff in private-etc to see what's truly needed

@lucasmz-dev
Copy link
Contributor Author

It wouldn't be possible to print out a message right? The ADB thing would be useful to print.

@kmk3
Copy link
Collaborator

kmk3 commented Jan 31, 2025

I'll do a test later today with the changes (even if they're only really
reordering AFAICT) and rebase/re-sign the commits with the proper credits

Feel free to just squash everything and just delete the Co-authored-by lines
for brevity, as the review was just basic stuff.

I should probably also look into the stuff in private-etc to see what's truly
needed

Speaking of that, does the tool actually need network access or was
private-etc @network,@tls-ca just added by --build?

It wouldn't be possible to print out a message right? The ADB thing would be
useful to print.

I had though about adding a warning command in the past, but there is currently
no command for that.

Also, could you try commenting/uncommenting parts of the profile until adb
works and then post the lines that cause the problem?

Depending on which lines are affected, it might be worth it to just disable
them to make adb work by default.

(Also you might need to add adb to private-bin).

@lucasmz-dev
Copy link
Contributor Author

I suspect it may have something to do with the plugdev group

@lucasmz-dev lucasmz-dev force-pushed the profile-device-flasher branch from 4fbc5d8 to 5ae3f30 Compare January 31, 2025 19:41
@lucasmz-dev
Copy link
Contributor Author

found the culprit for adb not working
something inside protocol, needs investigating

@lucasmz-dev
Copy link
Contributor Author

adding netlink solves it!

@lucasmz-dev lucasmz-dev force-pushed the profile-device-flasher branch from 5ae3f30 to afc0d6b Compare January 31, 2025 21:18
@lucasmz-dev lucasmz-dev marked this pull request as ready for review January 31, 2025 21:19
@lucasmz-dev lucasmz-dev marked this pull request as draft January 31, 2025 21:19
The CalyxOS CLI device flasher
@lucasmz-dev lucasmz-dev force-pushed the profile-device-flasher branch from afc0d6b to 64df5c5 Compare January 31, 2025 21:20
@lucasmz-dev lucasmz-dev marked this pull request as ready for review January 31, 2025 21:20
@lucasmz-dev
Copy link
Contributor Author

lucasmz-dev commented Jan 31, 2025

works perfectly now! i also went and removed some of the entries in private-bin that were debugging only (i thought in keeping it for someone who may wanna mess with other things themselves but... eh)
also removed the extra entries in private-etc

confirmed working with a flash to a devon device (Moto G32)
I'd assume Pixel to be safe given they're very similar, Fairphones may be different but I still don't think there'd be anything weird

@lucasmz-dev lucasmz-dev requested a review from kmk3 February 1, 2025 12:15
@kmk3 kmk3 merged commit a6f26b6 into netblue30:master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants