Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer-encoding: chunked and stuff. #7

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Transfer-encoding: chunked and stuff. #7

wants to merge 7 commits into from

Conversation

nclarkekb
Copy link
Contributor

@nclarkekb nclarkekb commented Jun 7, 2023 •
edited
Loading

No description provided.

nclarkekb added 5 commits June 3, 2023 14:45
@nclarkekb
Fixed minor javadoc problems blocking release procedure.
1903aa9
@nclarkekb
Modified WarcDate unittests to handle the different JDK date precisio…
d257855 
…ns. (JDK8 precision is millis and JDK9+ is nano precision)

Fixed some javadoc warnings reported in the build.
@nclarkekb
Reordered getting current date to after InetAddress.getLocalHost().ge…
bb6e9ac 
…tHostName() in case of lag getting hostname.

Should sort out those random errors where the dates differ more than 1 second in 2 unittests.
@nclarkekb
Support dual digest calculation of HTTP transfer-encoding: chunked.
790aa43 
Since the payload digest can either be the whole payload or the unchunked data.
@nclarkekb
Report bad chunked encoding if payload digest is not valid.
f36ecc0 
Added some constants.
@nclarkekb nclarkekb changed the title Kb Transfer-encoding: chunked and stuff. Jun 7, 2023
@csrster
Copy link
Contributor

csrster commented Jun 30, 2023 •
edited
Loading

There is a small problem that the code does not run correctly with Java 8 runtime - but neither does it fail in an immediately obvious way. This can be solved by upgrading the maven-compiler-plugin to 3.11.0 and replacing

<source>1.8</source>
<target>1.8</target>

with

<release>8</release>
in both jwat and jwat-tools.

@nclarkekb
Copy link
Contributor Author

I always compile using oracle jdk8. Are you using openjdk8 by any change.
Not that it matters, just curious.
But I will modify the pom and commit and it should show up in the pull request after that.

@csrster
Copy link
Contributor

csrster commented Jul 3, 2023

I always compile using oracle jdk8. Are you using openjdk8 by any change. Not that it matters, just curious. But I will modify the pom and commit and it should show up in the pull request after that.

I was compiling under Java 11.
cheers,
Colin

@nclarkekb
Copy link
Contributor Author

Added some profiles so JDK8 classes should now be produced when using JDK8-21.
Uses source/target when using JDK8 and release when using JDK9+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nclarkekb @csrster