enhancement(@nestjs/microservices) disable internal gRPC errors swallow

nestjs · Jul 4, 2018 · 3cf8607 · 3cf8607
1 parent 3d2d838
commit 3cf8607
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/microservices/client/client-grpc.ts b/packages/microservices/client/client-grpc.ts
@@ -128,9 +128,11 @@ export class ClientGrpcProxy extends ClientProxy implements ClientGrpc {
 
       const context = grpcPackage.load(options);
       return context;
-    } catch (e) {
+    } catch (err) {
       const invalidProtoError = new InvalidProtoDefinitionException();
-      this.logger.error(invalidProtoError.message, invalidProtoError.stack);
+      const message = err && err.message ? err.message : invalidProtoError.message;
+
+      this.logger.error(message, invalidProtoError.stack);
       throw invalidProtoError;
     }
   }

diff --git a/packages/microservices/server/server-grpc.ts b/packages/microservices/server/server-grpc.ts
@@ -155,9 +155,11 @@ export class ServerGrpc extends Server implements CustomTransportStrategy {
 
       const context = grpcPackage.load(options);
       return context;
-    } catch (e) {
+    } catch (err) {
       const invalidProtoError = new InvalidProtoDefinitionException();
-      this.logger.error(invalidProtoError.message, invalidProtoError.stack);
+      const message = err && err.message ? err.message : invalidProtoError.message;
+
+      this.logger.error(message, invalidProtoError.stack);
       throw invalidProtoError;
     }
   }

diff --git a/sample/04-grpc/src/grpc-client.options.ts b/sample/04-grpc/src/grpc-client.options.ts
@@ -1,4 +1,4 @@
-import { Transport, ClientOptions } from '@nestjs/microservices';
+import { ClientOptions, Transport } from '@nestjs/microservices';
 import { join } from 'path';
 
 export const grpcClientOptions: ClientOptions = {