Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cell_index and withdrawan_transaction_id to dao_event #2374

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

@zmcNotafraid zmcNotafraid requested a review from rabbitz December 30, 2024 03:06
Signed-off-by: Miles Zhang <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.

Project coverage is 55.49%. Comparing base (d43caaf) to head (faf41b4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../tasks/migration/fill_cell_index_to_dao_event.rake 10.71% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2374      +/-   ##
===========================================
- Coverage    55.60%   55.49%   -0.12%     
===========================================
  Files          373      374       +1     
  Lines        10759    10787      +28     
===========================================
+ Hits          5983     5986       +3     
- Misses        4776     4801      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmcNotafraid zmcNotafraid added this pull request to the merge queue Dec 30, 2024
Merged via the queue into nervosnetwork:develop with commit 3feb70f Dec 30, 2024
1 of 3 checks passed
@zmcNotafraid zmcNotafraid deleted the issue-297 branch December 30, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants