Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contract synchronization #1550

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Jan 2, 2024

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid January 2, 2024 08:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (5ad471d) 67.12%.
Report is 186 commits behind head on develop.

❗ Current head 5ad471d differs from pull request most recent head 4321a41. Consider uploading reports for the commit 4321a41 to get more accurate results

Files Patch % Lines
app/workers/charts/ckb_hodl_waves_statistic.rb 0.00% 45 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 43.75% 18 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 69.76% 13 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
app/models/concerns/display_cells.rb 92.68% 6 Missing ⚠️
app/services/das_indexer_service.rb 0.00% 6 Missing ⚠️
app/workers/update_address_info_worker.rb 0.00% 6 Missing ⚠️
app/controllers/api/v2/nft/transfers_controller.rb 71.42% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1550      +/-   ##
===========================================
+ Coverage    66.37%   67.12%   +0.74%     
===========================================
  Files          275      285      +10     
  Lines         7397     7729     +332     
===========================================
+ Hits          4910     5188     +278     
- Misses        2487     2541      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz enabled auto-merge January 2, 2024 09:22
@rabbitz rabbitz force-pushed the fix/sync_contract branch from 8b41e94 to 4321a41 Compare January 2, 2024 09:25
@rabbitz rabbitz added this pull request to the merge queue Jan 2, 2024
Merged via the queue into nervosnetwork:develop with commit 928b869 Jan 2, 2024
1 check passed
@rabbitz rabbitz deleted the fix/sync_contract branch January 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants