Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out invalid addresses in das accounts query #1518

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Nov 29, 2023

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid November 29, 2023 02:43
@codecov-commenter
Copy link

Codecov Report

Attention: 190 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (6976342) 67.45%.
Report is 150 commits behind head on develop.

❗ Current head 6976342 differs from pull request most recent head a42d7ab. Consider uploading reports for the commit a42d7ab to get more accurate results

Files Patch % Lines
...ib/tasks/migration/update_output_cells_status.rake 29.26% 29 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 19.23% 21 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
...ib/tasks/migration/async_missing_transactions.rake 15.78% 16 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 72.34% 13 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 72.97% 10 Missing ⚠️
lib/websocket.rb 0.00% 10 Missing ⚠️
lib/scheduler.rb 0.00% 7 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1518      +/-   ##
===========================================
+ Coverage    66.37%   67.45%   +1.07%     
===========================================
  Files          275      284       +9     
  Lines         7397     7669     +272     
===========================================
+ Hits          4910     5173     +263     
- Misses        2487     2496       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Nov 29, 2023
Merged via the queue into nervosnetwork:develop with commit 8ee1a35 Nov 29, 2023
1 check passed
@rabbitz rabbitz deleted the fix/das_accounts branch November 29, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants