Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle deployed_type_script with matching code_hash #1512

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Nov 23, 2023

No description provided.

@rabbitz rabbitz requested a review from zmcNotafraid November 23, 2023 02:27
@codecov-commenter
Copy link

Codecov Report

Attention: 187 lines in your changes are missing coverage. Please review.

Comparison is base (bb447e4) 66.37% compared to head (b90d870) 67.30%.
Report is 146 commits behind head on develop.

❗ Current head b90d870 differs from pull request most recent head 854b720. Consider uploading reports for the commit 854b720 to get more accurate results

Files Patch % Lines
...ib/tasks/migration/update_output_cells_status.rake 29.26% 29 Missing ⚠️
lib/tasks/migration/generate_referring_cells.rake 19.23% 21 Missing ⚠️
.../controllers/api/v1/ckb_transactions_controller.rb 39.28% 17 Missing ⚠️
app/workers/token_transfer_detect_worker.rb 10.52% 17 Missing ⚠️
...ib/tasks/migration/async_missing_transactions.rake 15.78% 16 Missing ⚠️
app/workers/contract_statistic_worker.rb 0.00% 15 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 71.73% 13 Missing ⚠️
app/controllers/api/v2/scripts_controller.rb 72.97% 10 Missing ⚠️
lib/websocket.rb 0.00% 10 Missing ⚠️
lib/scheduler.rb 0.00% 7 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1512      +/-   ##
===========================================
+ Coverage    66.37%   67.30%   +0.93%     
===========================================
  Files          275      283       +8     
  Lines         7397     7635     +238     
===========================================
+ Hits          4910     5139     +229     
- Misses        2487     2496       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Nov 23, 2023
Merged via the queue into nervosnetwork:develop with commit 18c936b Nov 23, 2023
1 check passed
@rabbitz rabbitz deleted the fix/deployed_cells branch November 23, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants