Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Assertion issues when exporting NeRFs to poisson meshes and pointclouds #3587

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fixing Assertion issues when exporting NeRFs to poisson meshes and pointclouds #3587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions nerfstudio/scripts/exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ def main(self) -> None:
pipeline.datamanager,
(VanillaDataManager, ParallelDataManager),
)
assert pipeline.datamanager.train_pixel_sampler is not None
pipeline.datamanager.train_pixel_sampler.num_rays_per_batch = self.num_rays_per_batch
if isinstance(pipeline.datamanager, VanillaDataManager):
assert pipeline.datamanager.train_pixel_sampler is not None
pipeline.datamanager.train_pixel_sampler.num_rays_per_batch = self.num_rays_per_batch

# Whether the normals should be estimated based on the point cloud.
estimate_normals = self.normal_method == "open3d"
Expand Down Expand Up @@ -329,8 +330,9 @@ def main(self) -> None:
pipeline.datamanager,
(VanillaDataManager, ParallelDataManager),
)
assert pipeline.datamanager.train_pixel_sampler is not None
pipeline.datamanager.train_pixel_sampler.num_rays_per_batch = self.num_rays_per_batch
if isinstance(pipeline.datamanager, VanillaDataManager):
assert pipeline.datamanager.train_pixel_sampler is not None
pipeline.datamanager.train_pixel_sampler.num_rays_per_batch = self.num_rays_per_batch

# Whether the normals should be estimated based on the point cloud.
estimate_normals = self.normal_method == "open3d"
Expand Down
Loading