BUGFIX: Render cke toolbar table dropdowns with data urls #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3897
Replaces #3898 by letting the data url be generated via build tooling instead of runtime
We leverage our custom defined
.dataurl.svgextension to let the build tooling use the data-url loader instead of inlining the svg contents.This is a regression from #3836 as it changes the default
.svgloading to "text" from "dataurl" and provides and alternative new.dataurl.svgloading with "dataurl" to handle the previous cases.What I did
How I did it
How to verify it
before:
after: