BUGFIX: Prevent warnings for unrecognized DOM props #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses React warnings related to invalid DOM attributes: - Removed `executeCommand` and `formattingUnderCursor` from being passed to DOM elements. - Ensured these props are only handled within components where they are relevant, preventing them from being incorrectly rendered on DOM elements. These update prevent unnecessary warnings in the console. Resolves: neos#3894
mhsdesign
reviewed
Dec 11, 2024
packages/neos-ui-ckeditor5-bindings/src/EditorToolbar/Helpers/renderToolbarComponents.js
Show resolved
Hide resolved
Sebobo
approved these changes
Feb 4, 2025
mhsdesign
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks for elaborating on the comment, i had a more deep look into it myself and now im pretty sure this is the wrong place.
The code plugin is actually shipped with the Neos.Demo and registered there: https://github.com/neos/Neos.Demo/blob/6ac18378d6d54a87663c8e20fe4eef1e30a50a3f/Resources/Private/CodeTagPlugin/src/manifest.js#L28
And here in the rendering we can also see the mistake, as we just pass the finalProps directly to the button without omitting anything:
Omitting the props in the Ui based on the arbitrary name is too high-level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses React warnings related to invalid DOM attributes:
executeCommandandformattingUnderCursorfrom being passed to DOM elements.These update prevent unnecessary warnings in the console.
Resolves: #3894