BUGFIX: Remove import site from site creation module and fix delete sites (9.0) #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehand This bases on the thesis that the created site's name will use the configuration "*" which by default uses the default preset.
…ns events - also add notes for this case
because a site deletion does not prune the content repository we cannot reimport the nodes
The CR security was introduced with neos#5298 And now fails when fetching the content graph or deleting nodes: > Read access denied for workspace "user-editor": User is a Neos Administrator without explicit role for workspace "user-editor" The herby proposed fix is not perfect but so is the whole site deletion, instead only the base workspace should need to be deleted and the others need to be rebased.
mhsdesign
changed the title
dlubitz
reviewed
Jan 23, 2025
| <legend>{neos:backend.translate(id: 'sites.createBlank', value: 'Create a blank site', source: 'Modules')}</legend> | ||
| In the content repository: "{defaultContentRepositoryForNewSites}" |
There was a problem hiding this comment.
We need a translation key here, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4719
In #5139 i removed the capabilities to create composer packages via web request which is now obsolete as we have the new CLI / Web setup: #4243
Now we can also reimplement 'import site' based on new SiteImportService from #5307 - the thing is this comes with some limitations like in use with CLI:
as proposed here Discussion improve site entity and site node relation #4470 (comment) the site must have a field to define the contentRepositoryId. In the current state we can only know via the to be created site name plus the site configuration in
Neos.Neos.sitesvia its name or the fallback*which is the 'destined' content repository.a current limitation of the setup is that it can really only be executed once. After the events are set deleting the site (soft, without pruning the cr) a reimport would just duplicate the events again which is not the desired step probably. For that we allow to prune the site via
flow cr:pruneAll. Those steps are to be used with care and not available via GUI.The advantage CLI gives us is that for example failures in the done replay and all other steps are not obscured and can easily be be debugged. Also for managing multiple content repositories or changing dimensions configuration changes have to be undertaken which is closer to CLI.
Further we found out that the limitation of running the import only once makes it unusable with no site setup because the backend doesnt really work and we can get rid of the import functionality: #4719 (comment)
Bugfix: Use
withoutAuthorizationChecksto remove site via user interfaceThe CR security was introduced with #5298
And now fails when fetching the content graph or deleting nodes:
The herby proposed fix is not perfect but so is the whole site deletion, instead only the base workspace should need to be deleted and the others need to be rebased.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions