FEATURE: Add findByCriteria and findByIdentifier flowQuery operation
#5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mficzel
force-pushed
the
feature/findByFlowQueryOperations
branch
3 times, most recently
from
ba3793b to
7f1a11d
Compare
mhsdesign
reviewed
Jan 10, 2025
| ); | ||
|
|
||
| /** @var Node $contextNode */ | ||
| foreach ($flowQuery->getContext() as $contextNode) { |
There was a problem hiding this comment.
maybe in this "next" generation of flowquery we want to forbid the functionality that we iterate over all context nodes and either throw if there are multiple nodes or just always pick the first one. Operating on multiple nodes might not give the expected ordering as one might think
There was a problem hiding this comment.
The one thing that i dislike most is that context can contain anything. Would really like to limit that to nodes
mficzel
force-pushed
the
feature/findByFlowQueryOperations
branch
from
7f1a11d to
70df082
Compare
`findByCriteria` allows to query the subgraph below the contextNode
arguments:
- string | null: nodeTypefilter
- string | null: propertyValueCriteria
- object{offset?:int, limit?:int} | null: pagination
`findByIdentifier` will find a node with the given aggregate id in the subgraph defined by the contextNode
arguments:
- string: nodeAggregateId
Resolves: neos#5434
mficzel
force-pushed
the
feature/findByFlowQueryOperations
branch
from
70df082 to
99a6542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findByCriteriaallows to query the subgraph below the each contextNodearguments:
findByIdentifierwill find a node with the given aggregate id in the subgraph of each contextNodearguments:
Resolves: #5434
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions