BUGFIX: #4614 NodeAggregateWasMoved change not marked as changed in correct dimension #5369
Conversation
…in correct dimension see neos#4614 (comment) for explanation
| // WORKAROUND: we simply use the event's DSP here as the origin dimension space point. | ||
| // But this DSP is not necessarily occupied. | ||
| // @todo properly handle this by storing the necessary information in the projection | ||
| // todo so we need to create a change if there is none???? |
There was a problem hiding this comment.
this will start to bite us with #5314 in place as scatter will be started to be used:
But i wonder if that is not already handled via modifyChange? I guess a test could answer that ...
\Neos\Neos\PendingChangesProjection\ChangeProjection::modifyChange
| /** | ||
| * @var DimensionSpacePoint $dimensionSpacePoint This is one of the *covered* dimension space points of the node aggregate and not necessarily one of the occupied ones. This allows us to move virtual specializations only when using the scatter strategy | ||
| */ | ||
| public DimensionSpacePoint $dimensionSpacePoint, |
There was a problem hiding this comment.
I think it wouldn't hurt to have the strategy in here if only for potential debugging help....
|
With our new solution how to get publishing release ready: #5387 so instead of putting the info from the original command into the event well just mark this change as changed in all affected dimensions and then allow it to be published from all dimensions that are affected. No selective dimension publishing.
|
see #4614 (comment) for explanation
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions