FEATURE: New workspace overview UX #5132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
force-pushed
the
feature/4255-new-workspace-management-ui
branch
from
04aaa45 to
8b34b1d
Compare
Sebobo
force-pushed
the
feature/4255-new-workspace-management-ui
branch
from
8a7ea9f to
5f7e14b
Compare
Sebobo
force-pushed
the
feature/4255-new-workspace-management-ui
branch
from
ec3d275 to
da2a0bc
Compare
Sebobo
force-pushed
the
feature/4255-new-workspace-management-ui
branch
2 times, most recently
from
57a021d to
658a0e2
Compare
Use http headers for proper status codes and transport flash messages
|
Created PR for updating URL for new review in Neos UI: neos/neos-ui#3904 |
We have to find out if we want to keep the feature and implement it in a more sensible way
|
I extracted the obsolete policy yaml removals into
as i felt they were to big to include here and deserve some additional information. They can be merged later. |
…nged changes This hack originally made in 4fe6b98 got lost due to parallel work and is herby reintroduced
mhsdesign
reviewed
Jan 6, 2025
Comment on lines
+21
to
+22
| // todo fixme | ||
| @process.addQuery = ${value + '?node=' + document.document.documentNodeAddress} |
Overhauls b830ee8 to use the translation helper to avoid duplicating code. This is done also in other places in php already.
Because of changes the base workspace will not be selectable > You cannot change the base workspace of workspace with unpublished changes. And thus also not part of the payload which crashes with a bad request (400): > Required argument "baseWorkspace" is not set. Instead, we make this parameter optional. Additionally, we ensure that the base workspace is different before issuing any change.
…update was not sorted ASC by title instead the order was slightly different ... neither ASC nor DESC. to ensure we dont have to deal with that we remove the update response by just using `forward()` letting the index action handle everything correctly
mhsdesign
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks to everyone who participated here or in all the discussions! Great to have this on the finish line!!!
I tested it out and fixed some bugs:
- BUGFIX: Allow to edit workspaces if they contain changes
- BUGFIX: Fix sorting glitch because the hot swapped WorkspaceTable
- BUGFIX: Show workspaces in overview if their parent workspace is no
And also resolved the last todos or made a followup pr. The code is now polished and can be merged!! :)
mhsdesign
force-pushed
the
feature/4255-new-workspace-management-ui
branch
from
3fbdfe4 to
c2a4e0e
Compare
…accessible we do this by checking if a workspaces base workspace does not appear in the list of workspaces. This is also true for the live workspace as its not part of the list so the `entryWorkspace.baseWorkspaceName == 'live'` check is now obsolete but it shows better what we are trying to do here for the normal case :D Also the dropdown of base workspaces must always show the current option even if it would not be re changeable in the current permission set from the current user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4255
A new HTMX based UI with improved usability for the workspace overview based on the package https://github.com/Sebobo/Shel.Neos.WorkspaceModule.
This change is the first milestone and contains the basic extraction of the module from the Neos.Neos package into a separate package and the rewrite of the templates to Fusion and the usage of HTMX.
Upgrade instructions:
If any part of the module was overwritten in a project, the change will break any of those adjustments.
But the module is now easier to adjust from the outside than before as it uses Fusion based rendering which can be extended by including additional Fusion paths via a
Views.yaml.Workspace disappears after changing visibility
This can happen for previously created workspaces or if the workspace was manipulated via CLI too.
For that case look into
If it says "There are no role assignments" or if no "USER" has the "ROLE" set to "MANAGER", then assign a user this workspace to make it effectively working (and private) again: