TASK: Remove usages of $node->subgraphIdentity->contentStreamId in structure adjustments
#5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Graph directly $this->projectedNodeIterator->nodeAggregatesOfType has been rewritten to $this->contentGraph->findNodeAggregatesByType The `ProjectedNodeIterator` was before neos#5028 required to encapsulate `findNodeAggregatesByType` to only work on the live workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves partially: #5043
1.) Remove now obsolete
ProjectedNodeIteratorand expose $contentGraph directly$this->projectedNodeIterator->nodeAggregatesOfType has been rewritten to
$this->contentGraph->findNodeAggregatesByType
The
ProjectedNodeIteratorwas before #5028 required to encapsulatefindNodeAggregatesByTypeto only work on the live workspace.2.) Remove calls to
$node->subgraphIdentity->contentStreamIdand ask the content stream id from the content graph like started via #5002Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions