!!! TASK: Remove concepts addQueryString and argumentsToBeExcludedFromQueryString in Neos

[mhsdesign]

Resolves: #5076

Upgrade instructions

The options addQueryString and argumentsToBeExcludedFromQueryString have been removed from Fluid and Fusions Node Uri-Building API.
Please consider using Flows actual routing or reimplement this feature yourself:

- root = Neos.Fusion:NodeUri {
-    addQueryString = true
-    argumentsToBeExcludedFromQueryString = ${['bar']}
- }
+ root = Neos.Fusion:NodeUri {
+    additionalParams = ${request.arguments.filter((value, key) => key != 'bar')}
+ }

Affected Fusion prototypes:

• Neos.Fusion:ActionUri
  • and its usages like Neos.Fusion:Link.Action's href
• Neos.Fusion:UriBuilder
• Neos.Neos:NodeLink
• Neos.Neos:NodeUri

Fluid view helpers with now removed addQueryString

• <neos:link.node />
• <neos:uri.node />

Fluid view helpers with now deprecated addQueryString

• <neos:uri.module />
• <neos:link.module />

Affected PHP APIs:

• LinkingService::createNodeUri
  • the parameters no. 8 & 9 are deprecated.

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[grebaldi]

👍 by 👀

[mficzel]

i like ... fine by 👀