TASK: Remove transaction closures from projections

[bwaidelich]

Removes the many transactional closures from our projections that made the code harder to read and especially made exceptions much harder to debug.

Due to our current architecture (see #4746) all Projection::apply() calls are wrapped in a transaction anyways

Related: #3854

[mhsdesign]

I guess this fixes our problem #4970 as well?

[mhsdesign]

Ah and i see #4988 will remove the whole DbalCheckpointStorage and thus my todo comment that would be solved via this pr. But thats oke thanks a lot!!

neos-development-collection/Neos.ContentRepository.Core/Classes/Infrastructure/DbalCheckpointStorage.php

Lines 118 to 121 in e5d9595

	if ($this->connection->isRollbackOnly()) {
	// TODO as described in https://github.com/neos/neos-development-collection/issues/4970 we are in a bad state and cannot commit after a nested transaction was rolled back.
	throw new \RuntimeException(sprintf('Failed to update and commit checkpoint for subscriber "%s" because the transaction has been marked for rollback only. See https://github.com/neos/neos-development-collection/issues/4970', $this->subscriberId), 1711964313);
	}

[mhsdesign]

Reviewed with hiding whitespace (what i normally dont like to do) but looks absolutely fine.

[mhsdesign]

Due to our current architecture (see #4746) all Projection::apply() calls are wrapped in a transaction anyways

okay so currently the nested transactions are obsolete? and how will this change with #4988 will there also be one transaction around?

[bwaidelich]

I'll add one beginTransaction call at the start and one commit call to the end of apply

[mhsdesign]

sounds good but you might want to have input from someone more qualified than a wall (me regarding this topic :D)