WIP: TAKS: Improve node address serialisation #5067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base64 can add = as padding wihch then is not allowed in get parameters
kitsunet
reviewed
May 18, 2024
|
|
||
| final public function toUriRepresentation(): string | ||
| { | ||
| return str_replace('=', '~', base64_encode(http_build_query($this->coordinates))); |
There was a problem hiding this comment.
Yikes, I might need ot understand how this is supposed to be used? Why not just jsonify?
|
Suggestion #5072 |
This was referenced May 19, 2024
|
As discussed in #5072 we want to stick with json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4892 with the intent to optimise the
NodeAddressuri serialisation.Currently using base64 + json produces bigger output for dsps and also the default case (empty) is not particular pretty.
Additionally base64 as used currently is actually not safe due the
=padding. Which could produce problems when used as query parameter.See also #4564 (comment) for the discussion
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions