Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove references to deprecate node read model properties #5066

Merged

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 18, 2024

See https://discuss.neos.io/t/neos-9-beta-10-release/6578

Upgrade instructions

Review instructions

I did a phpstorm rename of the properties aggregate id and name. For the subgraph identity i replaced them via an explict search:

->subgraphIdentity->visibilityConstraints
to:
->visibilityConstraints

this works perfect and phpstan doesnt complain.

No other changes have been made. All usages of ->subgraphIdentity->contentStreamId will be removed separately or even need other things to happen first. See #5043

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign merged commit 008d9bf into 9.0 May 19, 2024
12 checks passed
@mhsdesign mhsdesign deleted the task/removeReferencesToDeprecateNodeReadModelProperties branch May 19, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants