Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Add workspaceName to nodeAggregate #5063

Merged
merged 3 commits into from
May 18, 2024

Conversation

mhsdesign
Copy link
Member

Followup to #5042

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, +1 by reading

…ntentStreamId`

Adjust tests to assert on workspace name as well:

> And I expect this node aggregate to have the parent node aggregates ["lady-eleonode-rootford"]
@mhsdesign mhsdesign force-pushed the task/addWorkspaceNameToNodeAggregate branch from 6436bbb to 6149abf Compare May 18, 2024 06:58
@mhsdesign mhsdesign force-pushed the task/addWorkspaceNameToNodeAggregate branch from 3d77e67 to 16d17b2 Compare May 18, 2024 07:26
@mhsdesign mhsdesign merged commit ae9a19c into neos:9.0 May 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants