Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Combine two NodeTypeNotFoundExceptions into one #5048

Merged
merged 1 commit into from
May 15, 2024
Merged

TASK: Combine two NodeTypeNotFoundExceptions into one #5048

merged 1 commit into from
May 15, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 12, 2024 •
edited
Loading

Solves TODO: This and NodeTypeNotFound should be made similar

Upgrade instructions

Review instructions
Did a simple phpstorm rename of the NodeTypeNotFoundException class and removed it later

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign requested a review from bwaidelich May 13, 2024 13:44
bwaidelich
bwaidelich approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mhsdesign mhsdesign force-pushed the task/combineTwoNodeTypeNotFoundExceptionsIntoOne branch from 47a2609 to 1c58528 Compare May 15, 2024 15:29
@mhsdesign mhsdesign merged commit 8a4759a into neos:9.0 May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @bwaidelich