WIP: FEATURE: Overhaul NodeTypeManager #4999
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Apr 23, 2024
6 tasks
mhsdesign
reviewed
Apr 25, 2024
| /** | ||
| * @internal | ||
| */ | ||
| final class ClosureNodeTypeProvider implements NodeTypeProviderInterface |
There was a problem hiding this comment.
i would suggest LazyNodeTypeProvider::fromClosure
|
Merged 9.0 into it and will try to remove the label stuff #5020 again from your pr ;) |
mhsdesign
force-pushed
the
feature/4228-overhaul-nodetypemanager
branch
from
990381c to
3af6cdb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mhsdesign
reviewed
May 17, 2024
| @@ -527,18 +222,30 @@ public function getNodeTypeNameOfTetheredNode(NodeName $nodeName): NodeTypeName | |||
| * Otherwise, isNodeTypeAllowedAsChildToTetheredNode() needs to be called on the *parent node type*. | |||
| * | |||
| * @return boolean true if the $nodeType is allowed as child node, false otherwise. | |||
| * @deprecated with Neos 9.0 – {@see childNodeTypeConstraints} should be used instead | |||
| */ | |||
| public function allowsChildNodeType(NodeType $nodeType): bool | |||
There was a problem hiding this comment.
so it will be
$nodeType->childNodeTypeConstraints->isNodeTypeAllowed($nodeTypeNameInQuestion);
and not something to ask the nodetypemanager? ... seems to make sense.
…AsChildToTetheredNode` The providers will only gather the node types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because
NodeTypeDTONodeTypesProviderNodeTypePostprocessorInterfacetoNeos.NeosResolves: #4228