Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! TASK: Move ContentRepositoryId to SharedModel namespace #4891

Merged
merged 1 commit into from
Mar 16, 2024
Merged

!!! TASK: Move ContentRepositoryId to SharedModel namespace #4891

merged 1 commit into from
Mar 16, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 14, 2024 •
edited
Loading

Originally the content repository didnt know its id but with the change #4310 we added it.
Thats why i presume the ContentRepositoryId lived in the factory namespace.
But since we now like to expose it in the ContentRepository and in the to be conceptualised NodeIdentity the idea about its location changed. The dto does no longer belong to the Factory namespace.

ContentRepositoryId should not be in that namespace o.O

Originally posted in #4868 (comment)

Upgrade instructions

Instead of referencing Neos\ContentRepository\Core\Factory\ContentRepositoryId you should reference Neos\ContentRepository\Core\SharedModel\ContentRepository

(That can as well be a simple string replace)

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Feb 14, 2024
@mhsdesign mhsdesign mentioned this pull request Feb 14, 2024
Closed
35 tasks
@mhsdesign
Copy link
Member Author

Ui adjustments neos/neos-ui#3717

@mhsdesign mhsdesign mentioned this pull request Feb 14, 2024
Merged
@mhsdesign mhsdesign marked this pull request as draft February 18, 2024 10:56
@mhsdesign mhsdesign force-pushed the task/moveContentRepositoryId-to-correct-namespace branch from e572de6 to 0b501ee Compare March 15, 2024 08:28
@mhsdesign mhsdesign marked this pull request as ready for review March 15, 2024 08:28
@mhsdesign mhsdesign force-pushed the task/moveContentRepositoryId-to-correct-namespace branch from 0b501ee to 20d28de Compare March 16, 2024 16:20
bwaidelich
bwaidelich approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for taking care!

@mhsdesign
!!! TASK: Move ContentRepositoryId to SharedModel namespace
7c91277 
The dto does not belong to the `Factory` namespace.
@mhsdesign mhsdesign force-pushed the task/moveContentRepositoryId-to-correct-namespace branch from 20d28de to 7c91277 Compare March 16, 2024 16:34
@kitsunet kitsunet enabled auto-merge March 16, 2024 16:35
@mhsdesign mhsdesign requested review from kitsunet and dlubitz March 16, 2024 18:17
dlubitz
dlubitz approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG ... this means we also have to adopt all external packages. 🙈

@kitsunet kitsunet merged commit 4e6c2f0 into neos:9.0 Mar 16, 2024
9 checks passed
@mhsdesign
Copy link
Member Author

mhsdesign commented Mar 16, 2024 •
edited
Loading

jup, but we already have to because of the workspaces and subtree tags 😅

and its not that widely used, for example pure fusion packages wont be affected.

Anke and me discussed that after this week we should probably check on a few packages ^^

@mhsdesign mhsdesign deleted the task/moveContentRepositoryId-to-correct-namespace branch March 16, 2024 19:43
ahaeslich added a commit to neos/rector that referenced this pull request Mar 17, 2024
@ahaeslich
TASK: Adjust to movement of ContentRepositoryId to SharedModel na…
98b8c76 
…mespace

Relates: neos/neos-development-collection#4891
Relates: neos/neos-ui#3717
@ahaeslich ahaeslich mentioned this pull request Mar 17, 2024
Merged
ahaeslich added a commit to neos/redirecthandler-neosadapter that referenced this pull request Mar 17, 2024
@ahaeslich
TASK: Adjust to movement of ContentRepositoryId to SharedModel na…
563b02e 
…mespace

Relates: neos/neos-development-collection#4891
Relates: neos/neos-ui#3717
@ahaeslich ahaeslich mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@bwaidelich bwaidelich bwaidelich approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhsdesign @bwaidelich @dlubitz @kitsunet