Skip to content

Commit

Permalink
BUGFIX: Fix sorting glitch because the hot swapped WorkspaceTable on …
Browse files Browse the repository at this point in the history
…update was not sorted ASC by title

instead the order was slightly different ... neither ASC nor DESC.

to ensure we dont have to deal with that we remove the update response by just using `forward()` letting the index action handle everything correctly
  • Loading branch information
mhsdesign committed Jan 8, 2025
1 parent 6b046c2 commit bfb52da
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 29 deletions.
6 changes: 1 addition & 5 deletions Neos.Workspace.Ui/Classes/Controller/WorkspaceController.php
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,7 @@ public function updateAction(
)
);

$workspaceListItems = $this->getWorkspaceListItems($contentRepository);

$this->view->assignMultiple([
'workspaceListItems' => $workspaceListItems,
]);
$this->forward('index');
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,9 @@ Neos.Workspace.Ui.WorkspaceController.new = Neos.Fusion:Component {
/// array<string>
baseWorkspaceOptions = ${baseWorkspaceOptions}

renderer = Neos.Fusion:Match {
@subject = ${request.httpRequest.method}
# Render the create modal
@default = afx`
<Neos.Workspace.Ui:Component.Modal.Create
baseWorkspaceOptions={props.baseWorkspaceOptions}
/>
`
# Empty template for the delete response as the payload is contained in the HTTP headers
POST = ''
}
renderer = afx`
<Neos.Workspace.Ui:Component.Modal.Create
baseWorkspaceOptions={props.baseWorkspaceOptions}
/>
`
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ prototype(Neos.Workspace.Ui:Component.Modal.Edit) < prototype(Neos.Fusion:Compon
attributes.hx-post={form.getTarget()}
attributes.hx-disabled-elt="find button"
attributes.hx-on--after-request={'document.getElementById("' + private.popoverId + '").hidePopover()'}
attributes.hx-select="#workspace-module-content"
attributes.hx-target="#workspace-module-content"
attributes.hx-swap="outerHTML"
>
<section>
<fieldset>
Expand Down

0 comments on commit bfb52da

Please sign in to comment.