TASK: Introduce dedicated Options::withForceAbsolute

The filter like signatures dont feel quite right because they only have one argument ... and its a yagni to add new args

Neos.Neos/Classes/FrontendRouting/NodeUriBuilder.php

@@ -94,7 +94,7 @@ public function __construct(
      * These options will not be considered when building a preview uri {@see previewUriFor}
      *
      * - forceAbsolute:
-     *   Absolute urls for non cross-linked nodes can be enforced via {@see Options::$forceAbsolute}.
+     *   Absolute urls for non cross-linked nodes can be enforced via {@see Options::withForceAbsolute()}.
      *   In which case the base uri determined by the request is used as host
      *   instead of a possibly configured site domain's host.
      *
@@ -123,7 +123,7 @@ public function __construct(
      */
     public function uriFor(NodeAddress $nodeAddress, Options $options = null): UriInterface
     {
-        $options ??= Options::create();
+        $options ??= Options::createEmpty();
 
         if (!$nodeAddress->workspaceName->isLive()) {
             // we cannot build a human-readable uri using the showAction as

Neos.Neos/Classes/FrontendRouting/Options.php

@@ -9,7 +9,7 @@
  *
  * Example:
  *
- *   Options::create(forceAbsolute: true);
+ *   Options::createForceAbsolute()->withCustomFormat('json');
  *
  * @api for the factory methods; NOT for the inner state.
  */
@@ -27,32 +27,35 @@ private function __construct(
     }
 
     /**
-     * Creates an instance with the specified options
+     * Creates empty options. Chain any of the with* methods to create a new option set with different values.
+     */
+    public static function createEmpty(): self
+    {
+        return new self(false, '', []);
+    }
+
+    /**
+     * Creates options with option to enforced absolute urls for non cross-linked nodes.
+     *
+     * Alias for:
+     *
+     *     Options::createEmpty()->withForceAbsolute();
      *
-     * Note: The signature of this method might be extended in the future, so it should always be used with named arguments
-     * @see https://www.php.net/manual/en/functions.arguments.php#functions.named-arguments
      */
-    public static function create(
-        bool $forceAbsolute = null
-    ): self {
-        return new self(
-            $forceAbsolute ?? false,
-            '',
-            []
-        );
+    public static function createForceAbsolute(): self
+    {
+        return new self(true, '', []);
     }
 
     /**
-     * Returns a new instance with the specified additional options
+     * Option to enforce absolute urls for non cross-linked nodes.
      *
-     * Note: The signature of this method might be extended in the future, so it should always be used with named arguments
-     * @see https://www.php.net/manual/en/functions.arguments.php#functions.named-arguments
+     * Absolute urls are fully qualified with protocol and host.
      */
-    public function with(
-        bool $forceAbsolute = null
-    ): self {
+    public function withForceAbsolute(): self
+    {
         return new self(
-            $forceAbsolute ?? $this->forceAbsolute,
+            true,
             $this->format,
             $this->routingArguments
         );

Neos.Neos/Classes/Fusion/ConvertUrisImplementation.php

@@ -142,7 +142,7 @@ public function evaluate()
         $nodeAddress = NodeAddress::fromNode($node);
 
         $unresolvedUris = [];
-        $options = Options::create(forceAbsolute: $this->fusionValue('absolute'));
+        $options = $this->fusionValue('absolute') ? Options::createForceAbsolute() : Options::createEmpty();
 
         $possibleRequest = $this->runtime->fusionGlobals->get('request');
         if ($possibleRequest instanceof ActionRequest) {

Neos.Neos/Classes/Fusion/Helper/LinkHelper.php

@@ -110,7 +110,7 @@ public function resolveNodeUri(
 
         $nodeUriBuilder = $this->nodeUriBuilderFactory->forActionRequest($controllerContext->getRequest());
 
-        $options = Options::create();
+        $options = Options::createEmpty();
         $format = $controllerContext->getRequest()->getFormat();
         if ($format && $format !== 'html') {
             $options = $options->withCustomFormat($format);

Neos.Neos/Classes/Fusion/NodeUriImplementation.php

@@ -150,7 +150,7 @@ public function evaluate()
             $nodeUriBuilder = $this->nodeUriBuilderFactory->forActionRequest(ActionRequest::fromHttpRequest(ServerRequest::fromGlobals()));
         }
 
-        $options = Options::create(forceAbsolute: $this->isAbsolute());
+        $options = $this->isAbsolute() ? Options::createForceAbsolute() : Options::createEmpty();
         $format = $this->getFormat() ?: $possibleRequest->getFormat();
         if ($format && $format !== 'html') {
             $options = $options->withCustomFormat($format);

Neos.Neos/Classes/ViewHelpers/Link/NodeViewHelper.php

@@ -301,7 +301,7 @@ public function render(): string
 
         $nodeUriBuilder = $this->nodeUriBuilderFactory->forActionRequest($this->controllerContext->getRequest());
 
-        $options = Options::create(forceAbsolute: $this->arguments['absolute']);
+        $options = $this->arguments['absolute'] ? Options::createForceAbsolute() : Options::createEmpty();
         $format = $this->arguments['format'] ?: $this->controllerContext->getRequest()->getFormat();
         if ($format && $format !== 'html') {
             $options = $options->withCustomFormat($format);

Neos.Neos/Classes/ViewHelpers/Uri/NodeViewHelper.php

@@ -213,7 +213,7 @@ public function render(): string
 
         $nodeUriBuilder = $this->nodeUriBuilderFactory->forActionRequest($this->controllerContext->getRequest());
 
-        $options = Options::create(forceAbsolute: $this->arguments['absolute']);
+        $options = $this->arguments['absolute'] ? Options::createForceAbsolute() : Options::createEmpty();
         $format = $this->arguments['format'] ?: $this->controllerContext->getRequest()->getFormat();
         if ($format && $format !== 'html') {
             $options = $options->withCustomFormat($format);