Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Correctly mark nullable method parameters as nullable #3433

Merged
merged 3 commits into from
Jan 17, 2025
Merged

TASK: Correctly mark nullable method parameters as nullable #3433

merged 3 commits into from
Jan 17, 2025

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Jan 15, 2025

Follow up of #3429 for 9.0 branch after upmerges

kdambekalns
kdambekalns approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 by 👀

robertlemke
robertlemke approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@robertlemke robertlemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlubitz dlubitz merged commit 98ff7ad into neos:9.0 Jan 17, 2025
7 checks passed
@dlubitz dlubitz deleted the task/mark-nullable-method-parameters-as-nullable branch January 17, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@robertlemke robertlemke robertlemke approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

@mficzel mficzel Awaiting requested review from mficzel

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlubitz @robertlemke @kdambekalns