Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Fix override of runBare() in functional test #3421

Open
wants to merge 1 commit into
base: 8.3
Choose a base branch
from

Conversation

kdambekalns
Copy link
Member

As of PHPUnit 11 runBare() is a final method.

This was written ages ago by Sebastian Kurfürst, who recently said:

IMHO we wanted to run each test twice to run it without cache and
then with cache. But it seems this was broken anyways since a long
time – so we can drop it

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

As of PHPUnit 11 `runBare()` is a `final` method.

This was written ages ago by Sebastian Kurfürst, who recently said:

> IMHO we wanted to run each test twice to run it without cache and
> then with cache. But it seems this was broken anyways since a long
> time – so we can drop it
@kdambekalns
Copy link
Member Author

This is an excerpt from #3405 that fixes just the runBare() override, as that leads to a fatal error when "doing things" with PhpUnit 11…

Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we consider it worth fixing we can get around this restriction of runBare and achieve the same result in a similar way.

For that we would put all generic test functions in a trait and then have two TestClasses both using this trait but having different setup methods. That way we test the same interactions with differently configured views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants