Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! TASK: Deprecate concepts addQueryString and argumentsToBeExcludedFromQueryString #3352

Merged
merged 1 commit into from
May 20, 2024
Merged

!!! TASK: Deprecate concepts addQueryString and argumentsToBeExcludedFromQueryString #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Neos.Flow/Classes/Mvc/Routing/UriBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,13 @@ class UriBuilder

/**
* @var boolean
* @deprecated with Flow 9.0
*/
protected $addQueryString = false;

/**
* @var array
* @deprecated with Flow 9.0
*/
protected $argumentsToBeExcludedFromQueryString = [];

Expand Down Expand Up @@ -205,7 +207,7 @@ public function getCreateAbsoluteUri()
*
* @param boolean $addQueryString
* @return UriBuilder the current UriBuilder to allow method chaining
* @api
* @deprecated with Flow 9.0
*/
public function setAddQueryString($addQueryString)
{
Expand All @@ -215,7 +217,7 @@ public function setAddQueryString($addQueryString)

/**
* @return boolean
* @api
* @deprecated with Flow 9.0
*/
public function getAddQueryString()
{
Expand All @@ -228,7 +230,7 @@ public function getAddQueryString()
*
* @param array $argumentsToBeExcludedFromQueryString
* @return UriBuilder the current UriBuilder to allow method chaining
* @api
* @deprecated with Flow 9.0
*/
public function setArgumentsToBeExcludedFromQueryString(array $argumentsToBeExcludedFromQueryString)
{
Expand All @@ -238,7 +240,7 @@ public function setArgumentsToBeExcludedFromQueryString(array $argumentsToBeExcl

/**
* @return array
* @api
* @deprecated with Flow 9.0
*/
public function getArgumentsToBeExcludedFromQueryString()
{
Expand Down
5 changes: 3 additions & 2 deletions Neos.FluidAdaptor/Classes/ViewHelpers/FormViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,13 @@ public function initializeArguments()
$this->registerArgument('format', 'string', 'The requested format, e.g. ".html"', false, '');
$this->registerArgument('additionalParams', 'array', 'additional query parameters that won\'t be prefixed like $arguments (overrule $arguments)', false, []);
$this->registerArgument('absolute', 'boolean', 'If set, an absolute action URI is rendered (only active if $actionUri is not set)', false, false);
$this->registerArgument('addQueryString', 'boolean', 'If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'arguments to be removed from the URI. Only active if $addQueryString = true', false, []);
$this->registerArgument('fieldNamePrefix', 'string', 'Prefix that will be added to all field names within this form', false, null);
$this->registerArgument('actionUri', 'string', 'can be used to overwrite the "action" attribute of the form tag', false, null);
$this->registerArgument('objectName', 'string', 'name of the object that is bound to this form. If this argument is not specified, the name attribute of this form is used to determine the FormObjectName', false, null);
$this->registerArgument('useParentRequest', 'boolean', 'If set, the parent Request will be used instead ob the current one', false, false);
// @deprecated with Flow 9:
$this->registerArgument('addQueryString', 'boolean', 'Deprecated with Flow 9. If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'Deprecated with Flow 9. arguments to be removed from the URI. Only active if $addQueryString = true', false, []);

$this->registerUniversalTagAttributes();
}
Expand Down
5 changes: 3 additions & 2 deletions Neos.FluidAdaptor/Classes/ViewHelpers/Link/ActionViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ public function initializeArguments()
$this->registerArgument('section', 'string', 'The anchor to be added to the URI', false, '');
$this->registerArgument('format', 'string', 'The requested format, e.g. ".html"', false, '');
$this->registerArgument('additionalParams', 'array', 'additional query parameters that won\'t be prefixed like $arguments (overrule $arguments)', false, []);
$this->registerArgument('addQueryString', 'boolean', 'If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'arguments to be removed from the URI. Only active if $addQueryString = true', false, []);
$this->registerArgument('useParentRequest', 'boolean', 'If set, the parent Request will be used instead of the current one. Note: using this argument can be a sign of undesired tight coupling, use with care', false, false);
$this->registerArgument('absolute', 'boolean', 'By default this ViewHelper renders links with absolute URIs. If this is false, a relative URI is created instead', false, true);
$this->registerArgument('useMainRequest', 'boolean', 'If set, the main Request will be used instead of the current one. Note: using this argument can be a sign of undesired tight coupling, use with care', false, false);
// @deprecated with Flow 9:
$this->registerArgument('addQueryString', 'boolean', 'Deprecated with Flow 9. If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'Deprecated with Flow 9. arguments to be removed from the URI. Only active if $addQueryString = true', false, []);
}

/**
Expand Down
5 changes: 3 additions & 2 deletions Neos.FluidAdaptor/Classes/ViewHelpers/Uri/ActionViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,11 @@ public function initializeArguments()
$this->registerArgument('format', 'string', 'The requested format, e.g. ".html"', false, '');
$this->registerArgument('additionalParams', 'array', 'additional query parameters that won\'t be prefixed like $arguments (overrule $arguments)', false, []);
$this->registerArgument('absolute', 'boolean', 'By default this ViewHelper renders links with absolute URIs. If this is false, a relative URI is created instead', false, false);
$this->registerArgument('addQueryString', 'boolean', 'If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'arguments to be removed from the URI. Only active if $addQueryString = true', false, []);
$this->registerArgument('useParentRequest', 'boolean', 'If set, the parent Request will be used instead of the current one. Note: using this argument can be a sign of undesired tight coupling, use with care', false, false);
$this->registerArgument('useMainRequest', 'boolean', 'If set, the main Request will be used instead of the current one. Note: using this argument can be a sign of undesired tight coupling, use with care', false, false);
// @deprecated with Flow 9:
$this->registerArgument('addQueryString', 'boolean', 'Deprecated with Flow 9. If set, the current query parameters will be kept in the URI', false, false);
$this->registerArgument('argumentsToBeExcludedFromQueryString', 'array', 'Deprecated with Flow 9. arguments to be removed from the URI. Only active if $addQueryString = true', false, []);
}

/**
Expand Down
Loading