TASK: Phpstan level 2 for Flow 8.3 and ignore to be fixed things #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is used in the `PropertyConditionGenerator`. There we expect it to return a string. Additionally, the tests prove that indeed a string is returned and not an array. The `$subselectSql` at line 411 will hold this string value when running the `ContentSecurityTest` test: > SELECT n0_.persistence_object_identifier AS persistence_object_identifier_0 FROM neos_flow_tests_functional_security_fixtures_testentityb n0_ WHERE n0_.stringvalue = ?
mhsdesign
force-pushed
the
task/phpStanLevel2-backport83
branch
from
c51d0d4 to
b1ce5f0
Compare
6 tasks
mhsdesign
force-pushed
the
task/phpStanLevel2-backport83
branch
2 times, most recently
from
c1646dd to
0145b9a
Compare
mhsdesign
force-pushed
the
task/phpStanLevel2-backport83
branch
from
0145b9a to
883ad0b
Compare
dlubitz
reviewed
Jan 19, 2024
grebaldi
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Hi @mhsdesign,
I did a full review and added a bunch of comments. Nothing deal-breaking I suppose, mostly karma stuff. The only truly irritating spot is the one that @dlubitz pointed out already.
Also, I can confirm that phpstan analysis on level 2 works locally. Thanks a lot for taking the time to create those fixes 💯
You may go ahead and address/resolve/dismiss my comments as you see fit and I'll give you a 👍 in return :)
mhsdesign
force-pushed
the
task/phpStanLevel2-backport83
branch
from
9b62592 to
9079261
Compare
dlubitz
approved these changes
Jan 20, 2024
|
Thanks for taking care! |
mhsdesign
changed the title
grebaldi
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Thanks a lot, @mhsdesign! 👍
btw: Nice idea aliasing that InternalAopProxyInterface - much clearer now :)
|
Thank you for your quick re-reviews ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow 9 Pr #3217
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions