-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix entity movement in custom fluid types #1922
Fix entity movement in custom fluid types #1922
Conversation
Last commit published: 2dc17cb2b660267bf51d789ebb575c4a31bd4983. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1922' // https://github.com/neoforged/NeoForge/pull/1922
url 'https://prmaven.neoforged.net/NeoForge/pr1922'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1922
cd NeoForge-pr1922
curl -L https://prmaven.neoforged.net/NeoForge/pr1922/net/neoforged/neoforge/21.4.78-beta-pr-1922-fix-1.21.4-GH-1832-custom-fluid-type-movement/mdk-pr1922.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@neoforged/bots backport 1.21.3 |
Backporting to |
@Matyrobbrt backport to 1.21.3 failed. Click for failure reasonCommand './gradlew unpackSourcePatches' failed execution with error:
BUILD FAILED in 1s https://github.com/neoforged/PRActionRunner/actions/runs/12999959383 |
This comment has been minimized.
This comment has been minimized.
Created backport PR: #1925 |
🚀 This PR has been released as NeoForge version |
This PR fixes #1832 by patching
LivingEntity#travel
to handle custom fluid types, reimplementing a missing patch from 1.21.1 as described in the description of the linked issue.Tested through the
tests
client by diving into a pool filled withnew_fluid_test:test_fluid
(the creative search tab should yield a bucket for it) and trying to swim upwards. Before the fix, the player falls through it as if it wasn't there, but could not jump. After the fix, the player moves in the fluid like if it were water or lava, and can jump.