Remove floatFactory zindex: 1
#4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `zindex: 1` hardcoding in `FloatFactoryImpl.createPopup` to allow for other floating windows to be displayed underneath.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4816 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 273 273
Lines 25981 25981
Branches 5390 5390
=======================================
Hits 25628 25628
Misses 205 205
Partials 148 148 ☔ View full report in Codecov by Sentry. |
V-Mann-Nick
added a commit
to V-Mann-Nick/nix-home-manager
that referenced
this pull request
Nov 24, 2023
I opened a pull request with coc.nvim: neoclide/coc.nvim#4816
fannheyward
approved these changes
Nov 27, 2023
fannheyward
added a commit
that referenced
this pull request
Feb 28, 2024
00bd79e fix(tests): fix broken tests on nightly (#4901) bb6df56 feat(completion): add g:coc_disable_mappings_check (#4913) 901226b fix(symbols): close outline preview at closing (#4911) 4807b2d fix(symbol): don't decrease end.line for Python (#4909) 3232964 fix(links): improve regex of link (#4906) 4bb274c fix(highlight): check buffer exist to highlight (#4874) 23e0566 feat(model): use getbufinfo to check command line (#4902) b14c1e9 chore(ci): npm run lint bbb3ec7 chore(package): update eslint related (#4900) c2c7132 chore(package): update jest related (#4898) 820a49f feat(completion): add suggest.chineseSegments (#4833) e44b117 fix(configuration): merge dotted config (#4895) dc633ad fix(codeLens): clear whole buffer on resolving (#4812) ae9ddb7 fix(handler): increase inlayHint render debounce (#4805) a716465 fix(core): disable cached-dir for resolving root (#4827) a2a3eea refactor(window): use nvim_get_option_value (#4769) 53ec5ad fix(native): checkComplete for file/buffer/around (#4794) d35f0d0 fix(dialog): set nonumber for floating doc (#4870) d49c6ee fix(ui): wrap the url in quotes to open (#4832) e18f99b fix(client): ignore -1 abnormal exit (#4868) ebc63cf fix(rpc): check coc_status exists before unlet (#4850) 610f5a4 fix(tests): incorrect comparing (#4839) 45f8a11 fix(configuration): join local coc-settings.json (#4854) 02c4a31 fix issues #4879 and #4872 (#4885) 9c079ad feat(diagnostic): add `DiagnosticWithFileType` (#4881) 392264f feat(list): support moving by word in prompt (#4867) ddf40ce feat(list): support <C-space> and <C-_> mappings (#4863) 3de02d7 chore(deps): bump follow-redirects from 1.15.2 to 1.15.4 (#4856) e42d5dc fix: block Vim until completion resolve finishes (#4847) 0006118 chore(docs): Fix typo curosr => cursor (#4848) da5201d chore(README): Update Node.JS version required. (#4849) 9831f9b fix: keep autocmds on registering new one (#4846) f82e420 fix: always pass `opts.close` for dialog (#4835) e108777 fix: floatFactory should not set `zindex: 1` (#4816) 9c3723a fix: CocTagFunc jumps to wrong position if using tabs for indentation (#4810) e3f91b5 chore(deps-dev): bump @babel/traverse from 7.22.11 to 7.23.2 (#4783)
|
@all-contributors please add @V-Mann-Nick for code. |
|
I've put up a pull request to add @V-Mann-Nick! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
FloatFactoryImpl.createPopuphardcodes zindex: 1 which then gets passed to coc#dialog#create_cursor_float and afterwards to coc#float#create_float_win where it overwrites the default value of 50.A value of 1 will not allow any other floating window to be displayed underneath as
zindex > 0. This will for example make it impossible for documentation to be shown above the zen-mode plugin which works withzindexbut sets it to 40 expecting other floating windows to use the default of 50 or above.Solution
By removing the line which hardcodes
zindex: 1the floating window will have a defaultzindexvalue of 50 according to the neovim docs which seems more fitting.Open Questions
I do not understand why @chemzqm added this line. It would be interesting to know the background on this.
I am a first time contributor and honestly I am very unfamiliar with this project's source code or vim plugin development in general. I have looked for tests relevant to this setting but couldn't find any. Also I could not think of what to test regarding this change. If you have any suggestions I am happy to add some tests.